Skip to content

merge ARP networking and networking extensions area#1046

Merged
ameowlia merged 1 commit intocloudfoundry:mainfrom
sap-contributions:maxmoehl/merge-networking
Feb 6, 2025
Merged

merge ARP networking and networking extensions area#1046
ameowlia merged 1 commit intocloudfoundry:mainfrom
sap-contributions:maxmoehl/merge-networking

Conversation

@maxmoehl
Copy link
Member

@maxmoehl maxmoehl commented Jan 9, 2025

The networking extensions area is very small and most contributors in it are also actively contributing to Networking. This commit merges those two areas.

The only approver who is only in the networking extensions area is @plowin but as a long time contributor to both he also passes the bar for being a networking approver. Contributions in the cloudfoundry org:

The networking extensions area is very small and most contributors in it
are also actively contributing to Networking. This commit merges those
two areas.

The only approver who is only in the networking extensions area is
@plowin but as a long time contributor to both he also passes the bar
for being a networking approver.
@maxmoehl
Copy link
Member Author

maxmoehl commented Jan 9, 2025

I hope that this change doesn't cause the automation to somehow alter our repositories 😄

@beyhan beyhan requested a review from ameowlia January 13, 2025 09:51
@beyhan beyhan added the wg-arp label Jan 13, 2025
@stephanme
Copy link
Member

The automation won't change your repos but the teams granting access to the network extensions area will disappear, e.g. wg-app-runtime-platform-networking-extensions-approvers. Maybe you use those teams for Concourse authorisation.

@maxmoehl
Copy link
Member Author

The automation won't change your repos but the teams granting access to the network extensions area will disappear, e.g. wg-app-runtime-platform-networking-extensions-approvers. Maybe you use those teams for Concourse authorisation.

That's a good point, we will make sure to check that should we follow-through with this.

@ameowlia ameowlia merged commit 5adee50 into cloudfoundry:main Feb 6, 2025
@maxmoehl maxmoehl deleted the maxmoehl/merge-networking branch February 6, 2025 16:17
maxmoehl added a commit to sap-contributions/cf-community that referenced this pull request Mar 16, 2025
With cloudfoundry#1046 I added Patrick as an approver as part of the networking area
merge but missed that he already was an approver. This commit removes
the duplicate mention.
ameowlia pushed a commit that referenced this pull request Mar 17, 2025
With #1046 I added Patrick as an approver as part of the networking area
merge but missed that he already was an approver. This commit removes
the duplicate mention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants